Comments in BLEAdvertising are wrong/misleading

[thomasw-mitutoyo-ctl]

Board

not board related

Device Description

not board related

Hardware Configuration

not board related

Version

latest master (checkout manually)

IDE Name

none

Operating System

none

Flash frequency

none

PSRAM enabled

yes

Upload speed

none

Description

I was reading the code of BLEAdvertising() in order to understand the inner details and adapt my project to it.
I noticed that the code has different comments which do not match the implementation.

Several advertising types are different in the comments compared to the implementation. The implementation seems to be correct but the comment was probably copy/pasted and not adapted afterwards.

Example:

arduino-esp32/libraries/BLE/src/BLEAdvertising.cpp

Line 355 in 3502b9c

// [Len] [0x02] [LL] [HH]

The comment says 0x02, but later it uses 0x03:

arduino-esp32/libraries/BLE/src/BLEAdvertising.cpp

Line 357 in 3502b9c

cdata[1] = ESP_BLE_AD_TYPE_16SRV_CMPL; // 0x03

Sketch

none

Debug Message

none

Other Steps to Reproduce

none

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[SuGlider]

Thanks @thomasw-mitutoyo-ctl for the PR.