Skip to content
This repository was archived by the owner on Jan 14, 2022. It is now read-only.

Beautify #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Beautify #1

wants to merge 3 commits into from

Conversation

olaf-mandel
Copy link

Contains three changes:

  • Remove non-ASCII chars from English texts
  • Change encoding from GB18030 to UTF-8: For international users of the library, this is much more readable.
  • Convert new-lines from \r\n to \n: See the Git-Book.

TODO: can someone please translate the comment in dhcpserver.h to English?

@olaf-mandel
Remove non-ASCII chars from English texts
123a674 
One of the changes is a wrong dash-character in a command line
example in README.md: it would not work as originally written.

The other changes are double quotes and colons in English text:
no functional difference.
@olaf-mandel
Change encoding from GB18030 to UTF-8
5a9db3b 
For international users of the library, this is much more readable.

TODO: can someone please translate the comment in dhcpserver.h to
English?
@olaf-mandel
Convert new-lines from \r\n to \n
45054ff 
With GIT repositories, it is best practice to check in all text
files that do not _require_ \r\n line endings even on Linux and
Mac with pure \n line endings. See
https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#Formatting-and-Whitespace
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olaf-mandel