Add upload.py and internal python in tools #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When present, use a tools-installed python executable for any python calls. When tools/upload.py is present, use it in place of esptool-ck.exe. When neither of these are present, as in releases 2.5.0 and prior, use the prior behavior, unchanged.
igrr
approved these changes
Feb 23, 2019
Instead of a bunch of nested if-elses, use a list of strings to try iterating over to fins python(.exe). Replace 1-line if-else with ternary operator
|
Tested with all combinations: . linux boards.json install 2.5.0 (fallback to esptool-ck) . win boards.json install 2.5.0 (fallback to esptool-ck.exe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When present, use a tools-installed python executable for any python
calls.
When tools/upload.py is present, use it in place of esptool-ck.exe.
When neither of these are present, as in releases 2.5.0 and prior, use
the prior behavior, unchanged.