Tools - makecorever.py fixed packaging & avoid needless overwrites #9250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update packaging script w/ new arguments rewrite ci build pattern to only rewrite core_version.h once per job restore behaviour from esp8266#6414 for other cases
There was a problem hiding this comment.
Pull Request Overview
This PR resolves issue #9248 by refining the CI build process so that core_version.h is updated only once per job and restores previous behavior for other cases. It also updates packaging and test scripts to accommodate new arguments for makecorever.py.
- Refactor generate() in makecorever.py to return version content instead of writing directly to an output stream.
- Update test and packaging scripts to use new CLI arguments for makecorever.py.
- Modify prebuild hook command in tests/common.sh to reflect the updated tooling.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/makecorever.py | Refactored generate() and adjusted file output handling. |
| tests/sanity_check.sh | Updated invocation to use new CLI arguments for makecorever.py. |
| tests/common.sh | Added a prebuild hook pattern with new arguments in the command line. |
| package/build_boards_manager_package.sh | Revised command line arguments for makecorever.py in the packaging script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amend #9248
rewrite ci build pattern to only rewrite core_version.h once per job
restore behaviour from #6414 for other cases
update packaging script w/ new arguments