Tweaked base64_encode_value in cores/esp8266/libb64/cencode.cpp
#9227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refered to the original libb64 implementation and optimized time complexity of `base64_encode_value` from O(n) to O(1) Signed-off-by: linraymond2006 <[email protected]>
Signed-off-by: linraymond2006 <[email protected]>
|
So there are two places that encode b64 for our libs - HTTPClient and WebServer. Both client and server encode authorization header. Server also encodes file hash for etag. Which one is the problem here? Pretty sure you've seen the history of the file. Original implementation was from libb64, but the lookup table placed in flash instead of ram (like it is here; since it is not marked with PROGMEM which forces it into .irom section, it never gets loaded into ram). #6607 traded flash space for some math. PR trades it back for ram. Any significant reason to make the change? |
|
Oh I haven't notice that. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referred to the original libb64 implementation and optimized time complexity of
base64_encode_valuefrom O(n) to O(1). The existing method, which uses if-else statement, can slow down the execution speed.