Skip to content

WiFiServer - allow constructor without parameters #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

JAndrassy
Copy link
Contributor

with begin(port) available, the constructor doesn't have to get port. I hope you like the default port number 23.

@JAndrassy JAndrassy force-pushed the wifi_server_ctor_no_param branch from 7900789 to 2a33703 Compare November 11, 2023 07:04
@d-a-v
Copy link
Collaborator

d-a-v commented Nov 12, 2023

After re-reading the official API, you're telling that

  • Official and esp8266 Server constructor always have a port argument
  • Server::begin() can have a port argument or no argument

So you're adding a constructor without argument for coherency with Server::begin(port), is that so ?

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default port 23 instead of 80 on other implementations is one of the spices used for the taste of this core.

@d-a-v d-a-v merged commit ee95373 into esp8266:master Nov 12, 2023
@JAndrassy
Copy link
Contributor Author

default port 23 instead of 80 on other implementations is one of the spices used for the taste of this core.

I know :-)

@JAndrassy JAndrassy deleted the wifi_server_ctor_no_param branch November 13, 2023 06:28
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants