Skip to content

Free String memory on assign of "" or clear() #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Free String memory on assign of "" or clear() #8486

wants to merge 1 commit into from

Conversation

earlephilhower
Copy link
Collaborator

Fixes #8485

Whenever the empty C string is assigned or the .clear() method
called, free any heap allocated with the String.

@earlephilhower earlephilhower mentioned this pull request Feb 10, 2022
Open
6 tasks
@earlephilhower
Free String memory on assign of "" or clear()
4bd7b4d 
Fixes esp8266#8485

Whenever the empty C string is assigned or the .clear() method
called, free any heap allocated with the String.
erkr
erkr reviewed Nov 24, 2024
View reviewed changes
Copy link

@erkr erkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider this not desirable. Use case for reserve() is to avoid memory fragmentation. To reuse such a String , cleaning without releasing the reserved memory is required.
Strings can be freed this way already:

String reserved=String():

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erkr erkr erkr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String clear() does not free memory, only set length(0)
2 participants
@earlephilhower @erkr