Skip to content

[BREAKING] HW Serial swap and pin setting work only on a few pins #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2021
Merged

[BREAKING] HW Serial swap and pin setting work only on a few pins #7949

merged 2 commits into from
Mar 28, 2021

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Mar 28, 2021

Change return type from void to bool on affected functions, return false on failure.

d-a-v
d-a-v approved these changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devyte
devyte approved these changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the AVR and Due cores: no signature clash: they don't have these methods.
LGTM!

@devyte devyte merged commit 5ac64ff into esp8266:master Mar 28, 2021
@devyte
Copy link
Collaborator

devyte commented Mar 28, 2021

This is actually a breaking change due to signature change.

@devyte devyte changed the title HW Serial swap and pin setting work only on a few pins [BREAKING] HW Serial swap and pin setting work only on a few pins Mar 28, 2021
@dok-net dok-net deleted the hwserial branch March 29, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dok-net @devyte @d-a-v