Skip to content

BREAKING - Upgrade to upstream newlib 4.0.0 release #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 23, 2020
Merged

BREAKING - Upgrade to upstream newlib 4.0.0 release #7708

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1395ef9
Upgrade to upstream newlib 3.3.0 release
earlephilhower Nov 14, 2020
43a8df3
Upgrade to Newlib 4.0.0 - needs toochain rebuild
earlephilhower Nov 18, 2020
cb3aa7a
Merge branch 'master' into newlib330
earlephilhower Nov 18, 2020
b574826
Add new include files part of newlib update
earlephilhower Nov 18, 2020
418f267
Clean rebuild to newlib 4.0.0
earlephilhower Dec 1, 2020
a50843a
Merge branch 'master' of https://github.com/esp8266/Arduino into newl…
earlephilhower Dec 1, 2020
7faf5d8
Remove unneeded include file
earlephilhower Dec 1, 2020
e989171
Modified local isXXX functions in newlib
earlephilhower Dec 1, 2020
5ba4d33
Merge branch 'master' into newlib330
earlephilhower Dec 1, 2020
8298952
Adjust macro defined isXXX_l character classifiers
earlephilhower Dec 1, 2020
9540bbe
Dieable CI caching and fix time header include
earlephilhower Dec 1, 2020
38f12f0
The tools/sdk/libc directory isn't used, remove it
earlephilhower Dec 1, 2020
7d36d28
Fix 64-bit time for LittleFS
earlephilhower Dec 4, 2020
e9f7823
Update to jjsuwa-sys3175 additions to GCC and newlib
earlephilhower Dec 11, 2020
f15f254
Merge branch 'master' of https://github.com/esp8266/Arduino into newl…
earlephilhower Dec 11, 2020
58476d0
Rebuild w/addl GCC patches, new BearSSL flags
earlephilhower Dec 23, 2020
f66e46a
Remove one more redundant lib.a file
earlephilhower Dec 23, 2020
25b4bc4
Merge branch 'master' of https://github.com/esp8266/Arduino into newl…
earlephilhower Dec 23, 2020
01e7c85
Rebuild eboot with new G++
earlephilhower Dec 23, 2020
da5621d
Reapply GH CI caching to pull-requests
earlephilhower Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: '3.x'
# - name: Cache Linux toolchain
# id: cache-linux
# uses: actions/cache@v2
# with:
# path: ./tools/dist
# key: key-linux-toolchain
- name: Cache Linux toolchain
id: cache-linux
uses: actions/cache@v2
with:
path: ./tools/dist
key: key-linux-toolchain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc, changing 'key' will force it to use a different cache
it will be expired at some point, but it is not as clear as something like travis (rip)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I think generally we're OK and the un-done patch here was just a stopgap during development.

The original commenting-out was because the releases have a datestamp in them which ends up making all builds in a day conflict. So get.py would find gcc-20121101.tgz(from 9AM) in the cached dir and not try and d/l the newer one gcc-20121101.tgz(from 11AM). The cached version's MD5 would mismatch, so the build failed w/o a toolchain. Easy fix, drop the caching. W/everything coming from GH.com, anyway, the cache probably doesn't make much difference...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, speeds on github are really good, so cache most of the time takes longer than just fetching the sources directly...

I think it also could be this 'template', making key depend on the .json so it is always new whenever toolchain is modified

key: ${{ runner.os }}-${{ hashFiles('package/package_esp8266com_index.template.json') }}

via https://github.com/actions/cache#creating-a-cache-key

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an awesome idea! Right now the cache will grow w/obsolete versions of the tools, but one based on the JSON would fix that problem.

Did you want the PR for this? OTW I can throw it together quickly.

- name: Build Sketches
env:
TRAVIS_BUILD_DIR: ${{ github.workspace }}
Expand All @@ -57,12 +57,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: '3.x'
# - name: Cache Linux toolchain
# id: cache-linux
# uses: actions/cache@v2
# with:
# path: ./tools/dist
# key: key-linux-toolchain
- name: Cache Linux toolchain
id: cache-linux
uses: actions/cache@v2
with:
path: ./tools/dist
key: key-linux-toolchain
- name: Build Sketches
env:
TRAVIS_BUILD_DIR: ${{ github.workspace }}
Expand All @@ -85,12 +85,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: '3.x'
# - name: Cache Windows toolchain
# id: cache-windows
# uses: actions/cache@v2
# with:
# path: ./tools/dist
# key: key-windows-toolchain
- name: Cache Windows toolchain
id: cache-windows
uses: actions/cache@v2
with:
path: ./tools/dist
key: key-windows-toolchain
- name: Build Sketch
env:
TRAVIS_BUILD_DIR: ${{ github.workspace }}
Expand All @@ -117,12 +117,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: '3.x'
# - name: Cache Mac toolchain
# id: cache-mac
# uses: actions/cache@v2
# with:
# path: ./tools/dist
# key: key-mac-toolchain
- name: Cache Mac toolchain
id: cache-mac
uses: actions/cache@v2
with:
path: ./tools/dist
key: key-mac-toolchain
- name: Build Sketch
env:
TRAVIS_BUILD_DIR: ${{ github.workspace }}
Expand Down Expand Up @@ -255,12 +255,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: '3.x'
# - name: Cache Linux toolchain
# id: cache-linux
# uses: actions/cache@v2
# with:
# path: ./tools/dist
# key: key-linux-toolchain
- name: Cache Linux toolchain
id: cache-linux
uses: actions/cache@v2
with:
path: ./tools/dist
key: key-linux-toolchain
- name: Boards.txt diff
env:
TRAVIS_BUILD_DIR: ${{ github.workspace }}
Expand Down