Skip to content

Support for Server Side Events #7008 #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Support for Server Side Events #7008 #7009

wants to merge 0 commits into from

Conversation

ewaldc
Copy link
Contributor

@ewaldc ewaldc commented Jan 10, 2020

Enhancement request: support for Server Sent Events aka EventSource #7008
Code for review, examples to follow

@earlephilhower
Copy link
Collaborator

@ewaldc, looks like you didn't git add your changes to ESP8266WebServer.h so the new variable you're using is not defined. Can you add it and re-push?

@ewaldc ewaldc closed this Jan 12, 2020
@ewaldc
Copy link
Contributor Author

ewaldc commented Jan 14, 2020

@earlephilhower,
I have come to realize that it is not needed to change the API to support Server Sent Event as I was coding the example. Hence you may ignore/reject this PR.
I have submitted an SSE example using a separate PR for the ESPWebServer library though.
I may have messed up the example a bit as I forgot to take out my SSID/password (no big harm though, it's a test network with no internet access)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewaldc @earlephilhower