Block not only uart interrupts

[saloid]

Fixes #6564

[devyte]

Plesde don't use the ets_intr_lock/unlock functions or macros directly, their usage is flawed and can cause stability issues.
Instead, use the InterruptLock object for scoped and correct protection, including possible nesting.

[saloid]

I should use it in this way?:

InterruptLock *lock=new InterruptLock;

// time critical section

delete lock;

[d-a-v]

Easier than that:

// block to protect
{ 
    esp8266::InterruptLock lockAllInterruptsInThisScope;

    // code to protect
    ....
}
// no more protection here

check this example

[saloid]

In some places interrupts unlocks before scope ends. I think in this places better to use delete.

[d-a-v]

new and delete are slow, increase heap fragmentation and useless in this case.
what places are you thinking of ?

[saloid]

I have tested more:
with ETS_INTR_LOCK, InterruptLock or even with AutoInterruptLock with different (tried all 15) levels i still getting exception 0 inside WiFi.begin while requesting SPI status (and no exception if no SPI transfer happens at this time). But if I use ETS_SPI_INTR_DISABLE - all works fine.
Maybe in this case (to cover another possible interrupts) I need to write similar class to InterruptLock, but instead interrupt level store bit mask (ets_isr_mask)?

[devyte]

@saloid said:

In some places interrupts unlocks before scope ends

Please don't work on this over core v2.5.2. There are recent fixes related to lock/unlock that were merged recently and aren't released. What you said sounds like that.
Instead, please make absolutely sure you're testing and working on latest git.

[saloid]

Still getting same exceptions with the latest git version.

Instead, please make absolutely sure you're testing and working on latest git.