-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add interrupt section to docs #6560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
earlephilhower
commented
Sep 27, 2019
The Mac requires special handholding to allow SSL connections for get.py, so document those for end users.
Adds a section on interrupts to the docs and lists the restrictions and warnings about running long tasks. Fixes esp8266#6428
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there were some comments about slme of this already in section "why does my esp crash". It might be a good idea to cross check against that.
f0111b6
to
33d5f98
Compare
Updated w/your proofreading and requests.
The FAQ does have a section on Interrupts, too, but I though it would be better to make the IRQ restrictions front-and-center before things crash, too. The contents are pretty close and don't contradict each other. If you're really against it, I can drop the section in the reference.rst and just add a the bit about memory allocation in the FAQ bit. |
Oh, I'm completely in favor of this. Users have missed the current section enough times that I think an additional specific section would be beneficial, even if the info is duplicated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this.