Skip to content

Update the documentation with clearer paths and info on sub-modules #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update the documentation with clearer paths and info on sub-modules #5816

wants to merge 2 commits into from

Conversation

scottchiefbaker
Copy link

No description provided.

@scottchiefbaker
Copy link
Author

This should clear up some confusion that caused me to open #5804

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

--recursive is not mandatory

python get.py
```
- Restart Arduino
- Restart the Arduino IDE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would note that opening the boards manager (and letting it download indexes?) gives me the same effect as restarting the IDE (on Windows 10 at least). Same with library manager for libraries.
Seems to force Arduino to do a re-scan of directories.

@d-a-v d-a-v mentioned this pull request Mar 21, 2019
6 tasks
```
- Download binary tools (you need Python 2.7)

- This repo requires other tools (sub-modules) that we need to fetch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need that in the documentation
There's currently only one sub-sub-module tools/sdk/lwip2/builder/lwip2-src/ which is not necessary, because it is precompiled (in tools/sdk/lib/).

Or you could state:

Sub-sub modules are not necessary for a fully running repository. However they can be downloaded with the following command:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get a functioning toolchain you 100% need the submodules. You don't get pyserial or esptool without fetching the submodules.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am talking about sub-sub-modules

#5882 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you seeing a reference to sub-sub-modules in the README?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git clone --recursive takes everything, we only need one level

git clone ...
cd <dir>
git submodule update --init

git clone --recursive is the equivalent of

git clone ...
cd <dir>
git submodule update --init --recursive

check #5882 which is merged now

@d-a-v
Copy link
Collaborator

d-a-v commented May 25, 2019

@scottchiefbaker If you don't agree with current master can you fix this PR (or close and make another one) ?

@earlephilhower earlephilhower added the merge-conflict PR has a merge conflict that needs manual correction label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict PR has a merge conflict that needs manual correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants