Skip to content

IPv6: DHCP6 & NTP fix (lwIP fix from David J. Fiddes [email protected]) #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jan 22, 2019

Two PRs on lwip2 from David J. Fiddes [email protected]:

This bring parity between DHCPv4 and DHCPv6 allowing DHCPv6
servers to specify an SNTP server to use. Only a single SNTP
server slot is allocated to DHCPv6 (the same as v4).

Tests:

Start an esp8266 on a network which only provides IPv6
addresses via DHCPv6 with 0, 1 or 3 SNTP servers
configured
Verify that the SNTP is configured and that time is
correct with an updated IPv6.ino sketch that reports
SNTP servers and the current time

This fixes the restarting of the SNTP client when the network
interface has a valid IP address. This was broken in changeset
9246ef for IPv4.

Note that for IPv6 the SNTP server can take up to 15 seconds to
be used due to the async nature of stateless DHCPv6 and SLAAC.
For IPv4 it takes effect immediately as the address and SNTP
server come in the same packet.

Tests:

Verify operation on dual-stack IPv4/IPv6:
    DHCPv6 only network (no DHCPv4 server present)
    DHCPv4 and DHCPv6 network
Verify operation on IPv4 only stack
Check SNTP restart with LwIP logging enabled
Verify time is requested and received via Wireshark
Verify system time is set

@d-a-v d-a-v changed the title +dhcp6_set_ntp_servers (lwIP patch from David J. Fiddes [email protected]) IPv6: DHCP6 & NTP fix (lwIP fix from David J. Fiddes [email protected]) Jan 29, 2019
@d-a-v d-a-v requested a review from devyte January 29, 2019 10:07
@d-a-v d-a-v merged commit 7d512c4 into esp8266:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants