Skip to content

FunctionalScheduledTicker #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

FunctionalScheduledTicker #5024

wants to merge 1 commit into from

Conversation

hreintke
Copy link
Contributor

Implementation of functional callbacks to Ticker library
Adding option to schedule Ticker callback

Adding option to schedule Ticker callback
@hreintke
Copy link
Contributor Author

New PR identical to #4209

@devyte devyte self-assigned this Aug 10, 2018
@devyte devyte added this to the 2.5.0 milestone Aug 10, 2018
@devyte
Copy link
Collaborator

devyte commented Aug 10, 2018

@hreintke this doesn't look the same as #4209 . In fact, to my eye it looks like an earlier more primitive version, e.g.: _timer(nullptr) => _timer(0), no typedef std::function<void(void)> TickerFunction, etc.
Did something regress, or is this on purpose?

@hreintke
Copy link
Contributor Author

@devyte
It is the correct version for the scheduled and functional implementation,
Will check the details but the TickerFunction was from an earlier version which is updated to callback_function_t on request of igrr to make it compliant for naming conventions.

But : I missed the PR which added the Ticker::active() function (and also updated _timer(0) -> _timer(nullptr)0. Was already long time ago for the initial PR.

I will rebase to get this updated or make another PR.
Sorry for the inconvenience,

@devyte
Copy link
Collaborator

devyte commented Aug 10, 2018

No worries, as long as we're moving forward to getting this merged :)

@hreintke
Copy link
Contributor Author

Replaced by #5030

@hreintke hreintke closed this Aug 12, 2018
@hreintke hreintke deleted the Ticker_Functional_Scheduled branch August 15, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants