Skip to content

flash size: +2M(no spiffs) #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

flash size: +2M(no spiffs) #4988

wants to merge 2 commits into from

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 30, 2018

additionally:
board generator: comments and simplify
ldscripts: link error when trying to use spiffs when unavailable

exemple with 512k no spiffs and a sketch using spiffs:

/tmp/arduino_build_788324/arduino.ar(Updater.cpp.o):(.text._ZN12UpdaterClass5beginEji+0xc): undefined reference to `_SPIFFS_start'
/tmp/arduino_build_788324/arduino.ar(spiffs_api.cpp.o): In function `SPIFFSImpl::format()':
.../hardware/esp8266com/esp8266/cores/esp8266/spiffs_api.h:156: undefined reference to `_SPIFFS_end'
.../hardware/esp8266com/esp8266/cores/esp8266/spiffs_api.h:161: undefined reference to `_SPIFFS_page'
.../hardware/esp8266com/esp8266/cores/esp8266/spiffs_api.h:162: undefined reference to `_SPIFFS_block'
collect2: error: ld returned 1 exit status

This behavior is opened to discussion.
I think this could reduce administrative time regarding misconfiguration.

@d-a-v
flash size: +2M(no spiffs)
b0acc4f 
board generator: comments and simplify
ldscripts: link error when trying to use spiffs when unavailable
@d-a-v d-a-v mentioned this pull request Jul 30, 2018
Closed
devyte
devyte reviewed Jul 31, 2018
View reviewed changes
tools/boards.txt.py
f1m.update( flash_size(0x100000, '1M', '1m512', '512K SPIFFS', 499696, 0x7B000, 0x80000, 8192))
f2m = flash_size(0x200000, '2M', '2m0', 'no SPIFFS', 1044464, 0x100000)
f2m.update( flash_size(0x200000, '2M', '2m', '1M SPIFFS', 1044464, 0x100000, 0xFB000, 8192))
f4m = flash_size(0x400000, '4M', '4m1m', '1M SPIFFS', 1044464, 0x300000, 0xFB000, 8192)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a 4M0, at least for testing purposes if nothing else. I don't know if it's the case for everyone else, but I have a whole lot of boards and they're all 4MB flash.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in #5103

devyte
devyte approved these changes Jul 31, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor suggestion, see inline.

@TD-er TD-er mentioned this pull request Aug 30, 2018
Closed
@devyte
Copy link
Collaborator

devyte commented Aug 31, 2018

@d-a-v this has conflicts now, could you please resolve?

@d-a-v
Copy link
Collaborator Author

d-a-v commented Sep 3, 2018

replaced by #5103

@d-a-v d-a-v closed this Sep 3, 2018
@d-a-v d-a-v deleted the boards2m0 branch September 3, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-a-v @devyte