-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix intermittent host tests failure #4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Valgrind reported error trace:
|
6 re-runs of the host tests have passed so far, no issues seen. |
tests/host/Makefile
Outdated
@@ -51,8 +51,8 @@ TEST_CPP_FILES := \ | |||
core/test_md5builder.cpp \ | |||
|
|||
|
|||
CXXFLAGS += -std=c++11 -Wall -coverage -O0 -fno-common | |||
CFLAGS += -std=c99 -Wall -coverage -O0 -fno-common | |||
CXXFLAGS += -std=c++11 -Wall -coverage -O0 -fno-common -g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this -g intentional, or left over from debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can pull it out. At some point I want to add in valgrind as part of all host_tests, which will require it back in. We're building w/-o0
already so it's kind of a strange setup already...
MD5Builder tests have been randomly, non-repeatably failing due to a problem with the returned value of MD5Builder. Valgrind detected a strncpy with an overlapping memory range, which is an undefined operation. Fix it with a memmove instead, and get rid of a couple #define redefinitions which were causing compile warnings on the host side as well.
96b9a1f
to
bcc9e0c
Compare
Got 7 clean reruns of host_tests w/o the |
MD5Builder tests have been randomly, non-repeatably failing due to a problem
with the returned value of MD5Builder.
Valgrind detected a strncpy with an overlapping memory range, which is
an undefined operation. Fix it with a memmove instead, and get rid
of a couple #define redefinitions which were causing compile warnings
on the host side as well.