Fix the issue #3612 , Updating the SPIFFS to f5e26c4

[Lan-Hekary]

the same suggested modification in this pull request igrr/mkspiffs#27

further info in this issue pellepl/spiffs#165 and the commit pellepl/spiffs@f5e26c4

also don't forget to update the mkspiffs release
I guess this can only be done by you 😃

[igrr]

Thanks for the PR!

To make it easier to follow SPIFFS updates in the future, would you mind adding SPIFFS commit ID to your commit description (e.g. "SPIFFS: update to f5e26c4")?

I will then update this branch by adding new mkspiffs release.

[Lan-Hekary]

Done I will Update this PR description too

[me-no-dev]

@igrr are you postponing this to be in sync with mkspiffs?

[igrr]

Yes, I still need to update package links for mkspiffs, and revert the SPIFFS config option which caused compatibility issues with 2.3.0.

[Lan-Hekary]

about SPIFFS config options .. what are the options that are causing the compatibility issues ??

[igrr]

According to @me-no-dev it is https://github.com/igrr/mkspiffs/blob/master/spiffs/spiffs_config.h#L202, but it would be nice to test that (i.e. prepare FS with older version, try to read it with the new one).

[Lan-Hekary]

OK I got that .. I will test it now
I am using PlatformIO so it's easy to change between 2.30 and 2.4.0 cores in a line :D
should I make a pull request if I verified it of leave that to you guys ?

[me-no-dev]

I would vote for a separate PR just so it outlines the change, but whatever the boss says :)

[igrr]

Well, I didn't mean adding these extra changes to this PR. It can go in as is. Just would make sense to merge all changes (roughly) at the same time, to prevent someone from grabbing non-compatible versions of mkspiffs and arduino-esp8266.

[Lan-Hekary]

I tested the changes .. it seems OK and the compatibility is maintained across the different versions and I tested with various files some of them well above 25k and it's Perfectly OK ..

I will make another pull request in the mkspiffs with the this change ..
but I won't be able to do another PR here because I edited the master branch in my fork
( I know I should've made a new branch ... I won't make this mistake again :D )

actually I've been meaning to ask .. Do you have a Guide on how to make a proper PRs and mastering git commands ??? sometimes I have difficulties with git in how to manage the remote fork I am making modifications to ..

[Lan-Hekary]

@me-no-dev , actually this change is directly related to the issue mentioned in the PR's title
but I will do whatever the boss says :D