Skip to content

Fixes #3537 #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

cristovao-trevisan
Copy link

@cristovao-trevisan cristovao-trevisan commented Aug 22, 2017

Fixing #3537

@devyte
Copy link
Collaborator

devyte commented Nov 17, 2017

@cristovao-trevisan this doesn't look right to me. For starters, a global variable with the state of the retries means that only one write can be in effect at any single time.
I would expect that the caller checks the returned value, and implements a loop of retries. After a number of attempts that result in no data being sent, it gives up and closes.
Am I misunderstanding something?
@igrr what do you think?

@devyte
Copy link
Collaborator

devyte commented Dec 28, 2017

@igrr what are your thoughts about this?

@devyte devyte closed this Nov 14, 2018
@devyte
Copy link
Collaborator

devyte commented Nov 14, 2018

Closing due to previous comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants