Update NTPClient.ino #339
Merged
Update NTPClient.ino #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardwiring the IP address of one server into the program, look-up an IP address from the host name. This way you get a random server from the pool each time.
|
Maybe make it in another example, this adds a lot of overhead since it has to call the DNS. |
|
How much overhead does it really add? If an NTP server IP address is going to be hardwired into the code example, at least don't use one of the servers from a pool, especially not one specifically marked "All services busy, not recommended". Many people will copy and paste this example and use it as-is which could eventually lead to an overloading of the particular server. On the same note: change the update period to a much longer time for the same reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not hardwire the NTP server IP address into the code. Instead, look-up the IP address from the host name. This way you will get a different random server from the pool each time you make a request.