Skip to content

Added HEAD method #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Added HEAD method #3007

wants to merge 4 commits into from

Conversation

hawwwran
Copy link

@hawwwran hawwwran commented Mar 1, 2017

Added method HEAD, which allows to get just headers in the response from the server. So the server now accepts HEAD method and strips content ig the request method was HEAD.

I added error code 418 I'm a teapot, which is in RFC and there is no need to ignore it.

…rom the server. So the server now accepts HEAD method and strips content ig the request method was HEAD.

I added error code 418 I'm a teapot, which is in RFC and there is no need to ignore it.
@codecov-io
Copy link

Codecov Report

Merging #3007 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3007   +/-   ##
=======================================
  Coverage   27.82%   27.82%           
=======================================
  Files          20       20           
  Lines        3626     3626           
  Branches      656      656           
=======================================
  Hits         1009     1009           
  Misses       2441     2441           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04df3ad...6c2f8ce. Read the comment docs.

@earlephilhower earlephilhower added merge-conflict PR has a merge conflict that needs manual correction waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. labels Oct 1, 2019
@earlephilhower
Copy link
Collaborator

Thanks for your PR, but the core and libraries have changed enough that this PR now has a merge conflict.

Could you merge it manually with the latest core, so we can consider it for future releases?

@earlephilhower
Copy link
Collaborator

On inspection, we already have a HEAD method in ESP8266WebServer.

enum HTTPMethod { HTTP_ANY, HTTP_GET, HTTP_HEAD, HTTP_POST, HTTP_PUT, HTTP_PATCH, HTTP_DELETE, HTTP_OPTIONS };

if (_currentMethod == HTTP_HEAD) return;

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict PR has a merge conflict that needs manual correction waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants