Skip to content

Update filesystem.md #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

seanspotatobusiness
Copy link

I added a part about placing the ESP8266 module in bootload mode which is something worth including for confused noobs like me.

@codecov-io
Copy link

codecov-io commented Jan 28, 2017

Codecov Report

Merging #2904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2904   +/-   ##
======================================
  Coverage    27.8%   27.8%           
======================================
  Files          20      20           
  Lines        3625    3625           
  Branches      656     656           
======================================
  Hits         1008    1008           
  Misses       2441    2441           
  Partials      176     176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85e783...c25341e. Read the comment docs.

@igrr
Copy link
Member

igrr commented Jan 31, 2017

I'm not sure if this extra sentence actually clarifies something. If anything, i didn't get any instructions for placing the board into bootloader mode from my supplier. Also the concept of placing the board into bootloader mode may not be known to people who use boards with a circuit to enter download mode automatically.
How about changing this along the lines of "do whatever you normally do when uploading the sketch", which may include manual placing of the board into download mode, for some boards?

@seanspotatobusiness
Copy link
Author

There are boards that enter download mode automatically? I only have an Adafruit HUZZAH ESP8266 and I think you have to do it manually be pressing buttons. I think it would be good to rephrase the instructions in the way you suggested so it makes it clear to people who have to manually start the bootload mode without confusing people whose devices do it automatically.

@davisonja
Copy link

davisonja commented Jan 31, 2017 via email

@igrr
Copy link
Member

igrr commented Jan 31, 2017

Huzzah should be capable of entering download mode automatically, iirc. I don't have one myself, but if there are other huzzah users reading this, please share your experiences.

@seanspotatobusiness
Copy link
Author

The code I need to use was made for the Arduino so maybe it's a difference between the Arduino and NodeMCU code/IDE?

@vicnevicne
Copy link
Contributor

I would suggest :

  • If your board requires you to press a button (or other) when flashing a sketch, do the same operation now

Just my 2 cents

@igrr
Copy link
Member

igrr commented Jan 31, 2017

Yep, the sentence by @vicnevicne sounds OK.

Rephrase per comments
earlephilhower added a commit to earlephilhower/Arduino that referenced this pull request Sep 28, 2019
Trivial addition to filesystem upload documentation.

Supercedes esp8266#2904 which cannot merge due to file renames and massive
changes to the filesystem.rst file since it was pushed.
earlephilhower added a commit that referenced this pull request Sep 28, 2019
* Minor FS documentation change from #2904

Trivial addition to filesystem upload documentation.

Supercedes #2904 which cannot merge due to file renames and massive
changes to the filesystem.rst file since it was pushed.

* Fix periods on the steps, they are complete sentences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants