ClientConnection uses too much heap when streaming files #2871 #2874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
requested changes
Jan 17, 2017
| const uint8_t* buf = _datasource->get_buffer(will_send); | ||
| err_t err = tcp_write(_pcb, buf, will_send, TCP_WRITE_FLAG_COPY); | ||
| _datasource->release_buffer(buf, will_send); | ||
| size_t will_send = (can_send < left) ? can_send : left; |
There was a problem hiding this comment.
These lines seem to use TABs for indentation, but the original file uses spaces. Could you please reformat to match indentation of the surrounding code?
| @@ -333,6 +333,7 @@ class ClientContext | |||
| return _written; | |||
| } | |||
|
|
|||
| #define TCP_WRITE_CHUNK_SIZE 256 | |||
There was a problem hiding this comment.
Can we change this to a ClientContext member variable? Then we can later add an API to WiFiClient to configure the chunk size at runtime. This variable can be default-initalized to 256 for now.
|
Both requested changes done. |
igrr
approved these changes
Jan 31, 2017
Codecov Report@@ Coverage Diff @@
## master #2874 +/- ##
======================================
Coverage 27.8% 27.8%
======================================
Files 20 20
Lines 3625 3625
Branches 656 656
======================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.