Skip to content

Add functional callbacks to ticker #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add functional callbacks to ticker #2738

wants to merge 4 commits into from

Conversation

hreintke
Copy link
Contributor

@hreintke hreintke commented Dec 5, 2016

This PR adds functional callbacks to the Ticker class.
It is fully backward compatible.

I only did limited testing.
I you agree to the way of implementing I will test all options to finalize.

@codecov-io
Copy link

codecov-io commented Dec 5, 2016

Codecov Report

Merging #2738 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2738      +/-   ##
=========================================
- Coverage    27.8%   27.6%   -0.21%     
=========================================
  Files          20      20              
  Lines        3625    3655      +30     
  Branches      656     678      +22     
=========================================
+ Hits         1008    1009       +1     
- Misses       2441    2468      +27     
- Partials      176     178       +2
Impacted Files Coverage Δ
cores/esp8266/spiffs/spiffs_nucleus.c 41.78% <0%> (-0.31%) ⬇️
cores/esp8266/spiffs/spiffs_hydrogen.c 38.06% <0%> (-0.28%) ⬇️
cores/esp8266/spiffs/spiffs_gc.c 2.57% <0%> (-0.05%) ⬇️
cores/esp8266/WString.cpp 15.13% <0%> (-0.04%) ⬇️
cores/esp8266/Print.cpp 5.03% <0%> (-0.04%) ⬇️
cores/esp8266/spiffs_api.h 44.37% <0%> (ø) ⬆️
cores/esp8266/core_esp8266_noniso.c 0% <0%> (ø) ⬆️
cores/esp8266/spiffs/spiffs_check.c 0% <0%> (ø) ⬆️
cores/esp8266/Stream.cpp 17.42% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b32e6a...04d44c4. Read the comment docs.

napierala and others added 3 commits April 14, 2017 20:49
Small bug fix in which the TickerFunction that was passed to: void once_ms(uint32_t milliseconds, TickerFunction tf) was ignored.
Fix Ticker.h. Tickerfunction tf was ignored in once_ms
@devyte
Copy link
Collaborator

devyte commented Dec 31, 2017

@hreintke this PR looks sort of messed up. Could you please update it, or close it and make a new one?

@hreintke
Copy link
Contributor Author

OK, will do.

I'll keep this one open until I PR the new version.
Do you want this functional callback as single feature or should I also include the "scheduled_function" in one go.

@igrr
Copy link
Member

igrr commented Dec 31, 2017

I think that callback_t can be implicitly converted into std:: function<void(void)>. Maybe you could also remove the existing callback_t overload?

@hreintke
Copy link
Contributor Author

OK will be included

@devyte
Copy link
Collaborator

devyte commented Jul 27, 2018

@hreintke is this PR still valid, or is it superseded by #4209 ?

@hreintke
Copy link
Contributor Author

@devyte This PR is indeed superseded by #4209.
I had (have) trouble getting rebase to work, that is why I made a new PR.

@devyte
Copy link
Collaborator

devyte commented Jul 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants