-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add functional callbacks to ticker #2738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
=========================================
- Coverage 27.8% 27.6% -0.21%
=========================================
Files 20 20
Lines 3625 3655 +30
Branches 656 678 +22
=========================================
+ Hits 1008 1009 +1
- Misses 2441 2468 +27
- Partials 176 178 +2
Continue to review full report at Codecov.
|
Small bug fix in which the TickerFunction that was passed to: void once_ms(uint32_t milliseconds, TickerFunction tf) was ignored.
Fix Ticker.h. Tickerfunction tf was ignored in once_ms
@hreintke this PR looks sort of messed up. Could you please update it, or close it and make a new one? |
OK, will do. I'll keep this one open until I PR the new version. |
I think that callback_t can be implicitly converted into std:: function<void(void)>. Maybe you could also remove the existing callback_t overload? |
OK will be included |
Thanks! |
This PR adds functional callbacks to the Ticker class.
It is fully backward compatible.
I only did limited testing.
I you agree to the way of implementing I will test all options to finalize.