detect division by zero in map() to prevent exceptions #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will return -1 like AVR would
Current coverage is 27.80% (diff: 100%)@@ master #2397 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Jun 1, 2017
See esp8266/Arduino#2397 for details.
slaff
added a commit
to SmingHub/Sming
that referenced
this pull request
Jun 1, 2017
See esp8266/Arduino#2397 for details.
ADiea
reviewed
Jun 2, 2017
| if(divisor == 0){ | ||
| return -1; //AVR returns -1, SAM returns 0 | ||
| } | ||
| return (x - in_min) * (out_max - out_min) / divisor; |
There was a problem hiding this comment.
should be
divisor = in_max - in_min;
return .../divisor + out_min;
|
Hi @me-no-dev! The
EDIT: I'll place all information here because I'm not sure about the right version number. I'm using PIO. Best regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will return -1 like AVR would
connected to #2219