-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add support to Print::printf for printing from flash #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
305d060
Merge remote-tracking branch 'esp8266/master'
e9a5c48
Merge remote-tracking branch 'esp8266/master'
246edd3
Merge remote-tracking branch 'esp8266/master'
c130c17
Merge remote-tracking branch 'esp8266/master'
617206d
Merge remote-tracking branch 'esp8266/master'
039f4db
Merge remote-tracking branch 'esp8266/master'
e6578b4
Merge remote-tracking branch 'esp8266/master'
db26ef4
Merge remote-tracking branch 'esp8266/master'
3dba795
Merge remote-tracking branch 'esp8266/master'
f799ede
Merge remote-tracking branch 'esp8266/master'
e2ff86b
Merge remote-tracking branch 'esp8266/master'
7158fea
Merge remote-tracking branch 'esp8266/master'
0264347
Merge remote-tracking branch 'esp8266/master'
3cf75ca
Merge remote-tracking branch 'esp8266/master'
6b9edd4
Merge remote-tracking branch 'esp8266/master'
2aa3d3e
Merge remote-tracking branch 'esp8266/master'
cc132ec
Merge remote-tracking branch 'esp8266/master'
bdbf8ed
Merge remote-tracking branch 'esp8266/master'
5f7daf4
Merge remote-tracking branch 'esp8266/master'
4e27e14
Merge remote-tracking branch 'esp8266/master'
d8be9b1
Merge remote-tracking branch 'esp8266/master'
96632c1
Merge remote-tracking branch 'esp8266/master'
4cde698
Add support to Print::printf for printing from flash
19b67a0
Remove flash string helper printf
39ac1fe
Merge branch 'master' into printf-flash-helper
me-no-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about introducing Print:vprintf(PGM_P format, va_list argp) and make the other 2 use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed that printf all together. Check the latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough.