-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ArduinoOTA library change #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request! Could you please squash and rebase all the changes? |
Oh heck... I'd love to... Um, can I do that on the website? (New to this!) |
I think you have to use git client to do this, command line or GUI. |
Also please check the errors in examples: |
Ok, working on it! |
Update ArduinoOTA.h Fixed callbacks to allow lambda capture
Current coverage is 22.64%@@ master #2013 diff @@
==========================================
Files 19 19
Lines 3627 3627
Methods 326 326
Messages 0 0
Branches 1195 1195
==========================================
Hits 821 821
Misses 2507 2507
Partials 299 299
|
Ok, did I do it right? (sorry!) |
Not exactly, see this explanation :) If you don't feel like using the command line client, don't bother, I'll squash that myself. |
Made changes, and think I've merged them now... any further attempts at rebasing just lead to errors... (error: could not apply xxxx). Unfortunately never used git before, learning lots today! Thanks. |
Modified callbacks to allow lambda with capture list.