UdpNtpClient rewritten in a clearer, more pedantic fashion. #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * see https://www.eecis.udel.edu/~mills/database/rfc/rfc1305/rfc1305c.pdf | ||
| * https://tools.ietf.org/html/rfc1305 | ||
| */ | ||
|
|
There was a problem hiding this comment.
It is considered common good practice to start every header file with include guards.
Added guard lines
Current coverage is 31.03%@@ master #2008 diff @@
==========================================
Files 19 19
Lines 3629 3629
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1126 1126
Misses 2503 2503
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the classic UdpNtpCLient sketch by adding the structure of the Ntp data packet (as described in RFC1305) and referring to fields within the structure.
My objective is to encourage the writing of code easier to maintain, especially by someone other than the original author.