Skip to content

optimize pwm interrupt handler for better precision #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

optimize pwm interrupt handler for better precision #1267

wants to merge 11 commits into from

Conversation

me-no-dev
Copy link
Collaborator

next timer should be set before writing to GPIO and GPIO should not be written to if no pins are attached there.

@igrr
Copy link
Member

igrr commented Dec 22, 2015

Thanks, I've pulled the PWM optimization fix.

  • Regarding tcp status redefinition, this change breaks the following sketch (because CLOSED is not defined anymore).

    #include <ESP8266WiFi.h>
    
    void setup() {
      WiFiClient client;
      if (client.status() != CLOSED) {
        panic();
      }
    }
    
    void loop() {}
  • Additional alignment for pvPortMalloc and pvPortRealloc should not be necessary because the first thing pvPortMalloc does is a call to xPortWantedSizeAlign, which aligns the size to portBYTE_ALIGNMENT.

@igrr igrr closed this Dec 22, 2015
@me-no-dev
Copy link
Collaborator Author

that CLOSED needs to be defined only once. I can't begin to explain what a pain it is to write lwip tcp backed library outside of ESP8266WiFi.
It's a real problem and needs a resolution really. Maybe lwip haders should go to the core?
Regarding alignment. That is a big issue with SDK 1.5 and definitely gets fixed with overloading the functions. But SDK 1.5 is a whole topic on it's own... I have a branch that is still on 1.3 so I can actually do some networking with the ESP.
Maybe come by gitter for a conversation?

@tablatronix
Copy link
Contributor

Who wants to commit this ?

@me-no-dev
Copy link
Collaborator Author

gimme a sec and will do

@me-no-dev
Copy link
Collaborator Author

#1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants