Skip to content

Latest commit https://github.com/esp8266/Arduino/pull/7060 prevent compilation under windows with arduino IDE #7749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luc-github opened this issue Dec 9, 2020 · 4 comments · Fixed by #7750

Comments

@luc-github
Copy link
Contributor

  • [x ] This issue complies with the issue POLICY doc.
  • [x ] I have read the documentation at readthedocs and the issue is not addressed there.
  • [ x] I have tested that the issue is present in current master branch (aka latest git).
  • [x ] I have searched the issue tracker for a similar issue.
  • [ NA] If there is a stack dump, I have decoded it.
  • [ x] I have filled out all fields below.

Platform

Settings in IDE

  • Module: Nodemcu
  • Flash Mode: dio
  • Flash Size: 4MB
  • lwip Variant: v2 Lower Memory
  • Reset Method: nodemcu
  • Flash Frequency: 40Mhz
  • CPU Frequency: 160MHz
  • Upload Using: NA
  • Upload Speed: NA

Problem Description

#7060 prevent compilation as it use mkdir.exe and cp.exe which do not exist under windows: mkdir is part of Microsoft shell not and exe and cp is unix tool not present on windows

when linking the compilation failed with following error message

exec: "mkdir": executable file not found in %PATH%

if mkdir is workrounded the a new message pop up

exec: "cp": executable file not found in %PATH%

image

Workaround 1:
revert #7060 allows compillation

Workaround 2:
add mkdir.exe and cp.exe from coreutils (http://gnuwin32.sourceforge.net/packages/coreutils.htm) allows compillation

@earlephilhower
Copy link
Collaborator

@mhightower83, it should be a simple fix for this. Use the same form of cmd /c wrappers used elsewhere in the platform.txt calls and it should resolve w/o much grief.

@luc-github
Copy link
Contributor Author

luc-github commented Dec 9, 2020

additonnaly is that normal the build pass in travis/ci where there is a window image used?
is the ci reliable ?

@luc-github luc-github reopened this Dec 9, 2020
@earlephilhower
Copy link
Collaborator

Yeah, the Windows CI is behaving as expected. Unfortunately, to run the CI GH needs certain tools installed. I think they have almost a full mingw running (to allow their scripting/control/etc.).

mhightower83 added a commit to mhightower83/Arduino that referenced this issue Dec 9, 2020
Corrected recipe.hooks.prebuild.1x.pattern.windows in platform.txt and placed in proper order.
@luc-github
Copy link
Contributor Author

I close issue as fixed - thank you

d-a-v pushed a commit that referenced this issue Dec 10, 2020
Corrected recipe.hooks.prebuild.1x.pattern.windows in platform.txt and placed in proper order.
dok-net added a commit to dok-net/arduino-esp8266 that referenced this issue Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants