You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the transfer rate is stablished within the i2s_rxtx_begin() (and thus also i2s_begin()). This overwrites any data rate or div ratios previously introduced.
I suggest to clearly document that data rate must be specified always AFTER begin().
Alternatively, a (one time only) flag could be set as soon as rate or div ratios functions are called stopping that line from changing them.
Current behavior might create confusion (at least to me). I spent several hours figuring out why the rate would not stick. I understood it only after reading the code line by line. I suggest to take some action that could avoid that for other programmers.
The text was updated successfully, but these errors were encountered:
Fixesesp8266#6066
Preserve any existing sample rate for the I2S unit when performing an
`i2s_begin`. If nothing has ever been set, default to 44.1KHz as
before.
Fixes#6066
Preserve any existing sample rate for the I2S unit when performing an
`i2s_begin`. If nothing has ever been set, default to 44.1KHz as
before.
Platform
Irrelevant
Settings in IDE
Irrelevant
Problem Description
In:
Arduino/cores/esp8266/core_esp8266_i2s.cpp
Line 533 in f706c83
the transfer rate is stablished within the
i2s_rxtx_begin()
(and thus alsoi2s_begin()
). This overwrites any data rate or div ratios previously introduced.I suggest to clearly document that data rate must be specified always AFTER begin().
Alternatively, a (one time only) flag could be set as soon as rate or div ratios functions are called stopping that line from changing them.
Current behavior might create confusion (at least to me). I spent several hours figuring out why the rate would not stick. I understood it only after reading the code line by line. I suggest to take some action that could avoid that for other programmers.
The text was updated successfully, but these errors were encountered: