Skip to content

UMM_CALLOC doesn't check for NULL allocation #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
earlephilhower opened this issue Jan 21, 2018 · 1 comment
Closed

UMM_CALLOC doesn't check for NULL allocation #4207

earlephilhower opened this issue Jan 21, 2018 · 1 comment

Comments

@earlephilhower
Copy link
Collaborator

Found in debug of #4134

Arduino/cores/esp8266/umm_malloc/umm_malloc.c

Line 1688 in 0fe7259

memset(ret, 0x00, size);

UMM_CALLOC does an alloc then memset(0), but doesn't check the malloc succeeded, leading to a crash in UMM.
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Jan 21, 2018
@earlephilhower
Clear calloc block only if malloc succeeds
248ffb4 
Calloc was calling memset(0) on NULL when its implicit malloc failed,
causing a crash in UMM.  Instead, only do the memset if the memory
allocation succeeds.

Fixes issue esp8266#4207
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Jan 21, 2018
@earlephilhower
Clear calloc block only if malloc succeeds
f27e25e 
Calloc was calling memset(0) on NULL when its implicit malloc failed,
causing a crash in UMM.  Instead, only do the memset if the memory
allocation succeeds.

Fixes issue esp8266#4207
@earlephilhower earlephilhower mentioned this issue Jan 21, 2018
Merged
igrr pushed a commit that referenced this issue Jan 21, 2018
@earlephilhower @igrr
Clear calloc block only if malloc succeeds
589eb29 
Calloc was calling memset(0) on NULL when its implicit malloc failed,
causing a crash in UMM.  Instead, only do the memset if the memory
allocation succeeds.

Fixes issue #4207
@earlephilhower
Copy link
Collaborator Author

Closing, this was merged.

@tarzan115 tarzan115 mentioned this issue Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@earlephilhower