Skip to content

SPIFFS docs folder missing? #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holgerlembke opened this issue May 21, 2015 · 5 comments
Closed

SPIFFS docs folder missing? #299

holgerlembke opened this issue May 21, 2015 · 5 comments

Comments

@holgerlembke
Copy link
Contributor

I didn't find the SPIFFS docs folder as an subfolder of SPIFFS.

I think this folder should exist. Or at least a link where to find it.

https://github.com/pellepl/spiffs/tree/master/docs

igrr added a commit that referenced this issue May 21, 2015
@ghost
Copy link

ghost commented May 22, 2015

those files are in the spiffs folder

@holgerlembke
Copy link
Contributor Author

Why change folder structure without need?

I think imports from other projects should be kept as original as possible.

@ghost
Copy link

ghost commented May 23, 2015

are you really? so it's not ok the files to be there, they have to be in the same folder structure? Maybe leave the Makefile there too? Why? Did you forget about the tests? They are also not there...

@holgerlembke
Copy link
Contributor Author

yes.

Costs nothing and you can't be accused of "illegal modification".

@ghost
Copy link

ghost commented May 23, 2015

:D what modification? spiffs files are there as they were (well small adjustments were required, but they do not really count as such) We are talking about 3 files here... (they were 4 but one was empty). I see nothing illegal in reorganizing the folder to my liking. As I said I also removed the Makefile and the tests as those will build with the core every time...
I do not think that he will mind that at all... his code is there, his name is there, docs and whatnot as well.
Same goes for that other dude... shame on him.
And btw I did post a request for some additions in SPIFFS as I saw some problems trying to get everything to work. Sad I will not be around if he makes it.
Bye now :) Me has nothing to do with SPIFFS no moar

@igrr igrr closed this as completed Jul 28, 2015
igrr added a commit that referenced this issue Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants