-
Notifications
You must be signed in to change notification settings - Fork 13.3k
OTA completes without sending result to the client #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This looks like a regression caused by recent WiFiClient refactoring. Now that WiFiClient doesn't prevent Nagle algorithm from being used, some TCP segments may end up not being sent before restart is called. |
this problem exists too on "traditional" ota upadate (2.3-latest github) |
- fix response not being delivered to the browser after upload is done (#2221) - if Update.begin fails, don’t attempt to write data - if update is not successful, send error message from Update to the client - move strings into PROGMEM
Created #3219 to fix this |
- fix response not being delivered to the browser after upload is done (#2221) - if Update.begin fails, don’t attempt to write data - if update is not successful, send error message from Update to the client - move strings into PROGMEM
I have a very similar issue. When uploading the example BasicOTA sketch via OTA, the new firmware is uploaded 100%, and ESP reboots, but ArduinoIDE (Running in windows7) keeps waiting. |
HarmOtten did you find the cause? I have this problem repeatedly: 20:24:27 [INFO]: Sending invitation to: 192.168.10.103 20:24:39 [INFO]: Waiting for result... 20:26:45 [INFO]: Waiting for device... 20:26:57 [INFO]: Waiting for result... Where Upload size: 335056 |
@delwinbest, |
Basic Infos
Hardware
Hardware: ESP-12F
Core Version: git master
Description
HTTP_POST Problem
Does not work the return of status after upgrading the from the library ESP8266HTTPUpdateServer.
Settings in IDE
Module: Generic ESP8266 Module
Sketch
ESP8266HTTPUpdateServer/examples/WebUpdater/
The text was updated successfully, but these errors were encountered: