Skip to content

Check return value of udp_send and forward it WiFiUdp::endPacket #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
everslick opened this issue Feb 28, 2016 · 3 comments
Closed

Check return value of udp_send and forward it WiFiUdp::endPacket #1696

everslick opened this issue Feb 28, 2016 · 3 comments

Comments

@everslick
Copy link
Contributor

I see high packet loss when sending rapid UDP packets without yield() or delay(). A yield() after each packet does only help slightly, but delay(1) after each Udp.write() works around that bug.

Problem description:

The MAC layer seems to drop packets if the send queue is full, but this condition is not reported back to the application (endPacket() should return 0 in this case).

@igrr igrr self-assigned this Feb 29, 2016
@igrr igrr added this to the 2.2.0 milestone Feb 29, 2016
@igrr igrr changed the title errors from netif->output will bubble up to udp_send, but we aren't forwarding them to WiFiUdp class Check return value of udp_send and forward it WiFiUdp::endPacket Feb 29, 2016
@igrr
Copy link
Member

igrr commented Mar 2, 2016

I have addressed this in commit aa67d1c, however it appears that udp_sendto doesn't actually return errors when underlying packet buffer is full.

@everslick
Copy link
Contributor Author

so i guess it's up to espressif to fix this then. :-/ no idea where to
report this though.

On Wed, Mar 2, 2016 at 6:00 PM, Ivan Grokhotkov [email protected]
wrote:

I have addressed this in commit aa67d1c
aa67d1c,
however it appears that udp_sendto doesn't actually return errors when
underlying packet buffer is full.


Reply to this email directly or view it on GitHub
#1696 (comment).

@electron1979
Copy link

electron1979 commented Sep 29, 2016

May be related to my problem. Issue #2340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants