Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: make no-unused-vars not reporting enum members #558

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions analyze-scope.js
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,11 @@ class Referencer extends OriginalReferencer {
const scope = this.currentScope();

scope.__define(id, new Definition("EnumMemberName", id, node));

// Set `eslintUsed` flag to the defined variable because the enum member is obviously exported.
const variable = scope.set.get(id.name);
variable.eslintUsed = true;

if (initializer) {
scope.__referencing(
id,
Expand Down
8 changes: 4 additions & 4 deletions tests/lib/__snapshots__/scope-analysis.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2441,7 +2441,7 @@ Object {
"type": "EnumMemberName",
},
],
"eslintUsed": undefined,
"eslintUsed": true,
"identifiers": Array [
Object {
"name": "A",
Expand Down Expand Up @@ -2488,7 +2488,7 @@ Object {
"type": "EnumMemberName",
},
],
"eslintUsed": undefined,
"eslintUsed": true,
"identifiers": Array [
Object {
"name": "B",
Expand Down Expand Up @@ -2535,7 +2535,7 @@ Object {
"type": "EnumMemberName",
},
],
"eslintUsed": undefined,
"eslintUsed": true,
"identifiers": Array [
Object {
"name": "C",
Expand Down Expand Up @@ -2790,7 +2790,7 @@ Object {
"type": "EnumMemberName",
},
],
"eslintUsed": undefined,
"eslintUsed": true,
"identifiers": Array [
Object {
"name": "BAR",
Expand Down
18 changes: 18 additions & 0 deletions tests/lib/scope-analysis.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,4 +370,22 @@ function test(file: Blob) {

expect(messages).toStrictEqual([]);
});

test("https://github.com/eslint/typescript-eslint-parser/issues/553", () => {
const code = `
enum Foo {
BAR = 'bar'
}
Foo
`;
const config = {
parser: "typescript-eslint-parser",
rules: {
"no-unused-vars": "error"
}
};
const messages = linter.verify(code, config, { filename: "issue.ts" });

expect(messages).toStrictEqual([]);
});
});