Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Chore: Make ESLint a devDependency/peerDependency (fixes #523) #526

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Chore: Make ESLint a devDependency/peerDependency (fixes #523) #526

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f75d48
Chore: Make ESLint a devDependency/peerDependency (fixes #523)
platinumazure Oct 13, 2018
969094d
Chore: Open eslint peerDependency range to allow 5.x
platinumazure Oct 20, 2018
f245b93
Merge branch 'master' into eslint-peer-dependency
JamesHenry Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
},
"license": "BSD-2-Clause",
"devDependencies": {
"eslint": "^4.19.0",
"eslint-config-eslint": "4.0.0",
"eslint-plugin-node": "6.0.1",
"eslint-release": "0.11.1",
Expand Down Expand Up @@ -48,10 +49,10 @@
"betarelease": "eslint-prerelease beta"
},
"dependencies": {
"eslint": "4.19.1",
"typescript-estree": "2.1.0"
},
"peerDependencies": {
"eslint": "^4.19.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move to eslint 5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I had intended to leave it open but I should have used >=. I'll check the ESLint migration guide and, if feasible/not breaking, make that change this weekend. (Fairly sure it can be done without breaking users but just want to check.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ficristo This is fixed. Sorry for the delay.

"typescript": "*"
},
"jest": {
Expand Down