New: Attaches comments to the ESTree AST (fixes #31)

[JamesHenry]

See #34 for all the discussion leading up to this implementation

[eslintbot]

LGTM

[nzakas]

It looks like there are a bunch of unrelated changes in this file?

[JamesHenry]

In some cases they are required, in some cases they surfaced as bugs/missing checks when implementing the original work on this branch. Please see my comment below.

[nzakas]

As noted inline, it looks like there are a lot of unrelated changes in this PR. Can you narrow it down so the changes are only related to finding the comments?

[JamesHenry]

It is not as simple as saying they are unrelated to finding the comments... For example:

case SyntaxKind.TrueKeyword:
                assign(result, {
                    type: "Literal",
                    value: true,
                    raw: "true" // <- This was added in the PR
                });
                break;

The addition of the raw values for TrueKeyword, FalseKeyword and NullKeyword is necessary to make the attach-comments tests pass.

[nzakas]

Oh I see, thanks for explaining. In that case, I think this is good to go.

[JamesHenry]

Great, thanks!