Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Chore: Update README with list of known issues #247

Merged
merged 2 commits into from
May 6, 2017

Conversation

soda0289
Copy link
Member

@soda0289 soda0289 commented May 2, 2017

This commit updates the README with a list of known issues with ESLint rules and plugins.

@JamesHenry I think by providing a list of known issues with this parser we can help new users get started and cut back on duplicate issues. I don't mind when people open issues on failing rules or plugins as it helps determine the work needed to make the parser fully support eslint. Do you think this is a worth while change or might be better served by documentation?

@corbinu @mattdell @flying-sheep Did I miss any known issues with this parser and eslint?

This commit updates the README with a list of known issues with ESLint rules and plugins.
@soda0289 soda0289 requested a review from JamesHenry May 2, 2017 03:11
@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@aladdin-add
Copy link
Member

aladdin-add commented May 2, 2017

can we add known issues to ISSUE_TEMPLATE.md?

@soda0289
Copy link
Member Author

soda0289 commented May 2, 2017

@aladdin-add We probably should. Not sure if a link to the README would be sufficient. Or if we should add more documentation with common work arounds too.

README.md Outdated
The following TypeScript syntax will cause rules to fail or ESLint v3 to crash:
- Empty body functions
- Abstract methods
- Multiple function declarations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this referring to function overloads?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes function overloading. I can change the name to be more clear.

I'm going to write up an issue for this problem. I think we might be able to come up with a better solution than the one I have proposed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#253 Summarizes the current situation and the three PR's I created to fix this issue.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please just update that Multiple function declarations point so it is clear that it is referring to function overloads, then we can merge this

@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@JamesHenry JamesHenry merged commit aade6bd into master May 6, 2017
@JamesHenry JamesHenry deleted the update-readme-known-issues branch May 6, 2017 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants