-
-
Notifications
You must be signed in to change notification settings - Fork 75
Chore: Update README with list of known issues #247
Conversation
This commit updates the README with a list of known issues with ESLint rules and plugins.
Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
can we add known issues to |
@aladdin-add We probably should. Not sure if a link to the README would be sufficient. Or if we should add more documentation with common work arounds too. |
README.md
Outdated
The following TypeScript syntax will cause rules to fail or ESLint v3 to crash: | ||
- Empty body functions | ||
- Abstract methods | ||
- Multiple function declarations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this referring to function overloads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes function overloading. I can change the name to be more clear.
I'm going to write up an issue for this problem. I think we might be able to come up with a better solution than the one I have proposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#253 Summarizes the current situation and the three PR's I created to fix this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please just update that Multiple function declarations
point so it is clear that it is referring to function overloads, then we can merge this
Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
This commit updates the README with a list of known issues with ESLint rules and plugins.
@JamesHenry I think by providing a list of known issues with this parser we can help new users get started and cut back on duplicate issues. I don't mind when people open issues on failing rules or plugins as it helps determine the work needed to make the parser fully support eslint. Do you think this is a worth while change or might be better served by documentation?
@corbinu @mattdell @flying-sheep Did I miss any known issues with this parser and eslint?