This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Support superTypeParameters (fixes #242) #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
5 tasks
|
Do you think we should have a new node for class extensions/superClass? That way we could keep the type parameter together with the identifier. Kind of like how we have a ClassImplements node |
|
On second thought a new node for super class would mean we differ the estree spec and might cause eslint rules to break. |
azz
force-pushed
the
bug/super-type-parameters
branch
from
e5a6259 to
d64ef1f
Compare
|
LGTM |
|
Just pushed a new test with mixin classes. Does the AST look ok? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
superTypeParametersfield to theClassExpression/ClassDeclarationAST nodes.prettier/prettier#1422