Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Dependencies update (TS 1.8.7) #23

Closed
wants to merge 1 commit into from
Closed

Dependencies update (TS 1.8.7) #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,19 @@
}
],
"devDependencies": {
"chai": "^1.10.0",
"dateformat": "^1.0.11",
"eslint": "^2.2.0",
"eslint-config-eslint": "^3.0.0",
"eslint-release": "^0.3.0",
"istanbul": "~0.2.6",
"leche": "^1.0.1",
"mocha": "^2.0.1",
"npm-license": "^0.2.3",
"semver": "^4.1.1",
"shelljs": "^0.3.0",
"shelljs-nodecli": "^0.1.1"
"chai": "3.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to hardcode dependency versions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you prefer to have broken version because of someone changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these. Thanks.

"dateformat": "1.0.11",
"eslint": "2.2.0",
"eslint-config-eslint": "3.0.0",
"eslint-release": "0.3.0",
"istanbul": "0.4.2",
"leche": "2.1.1",
"mocha": "2.0.1",
"npm-license": "0.3.1",
"semver": "5.1.0",
"shelljs": "0.6.0",
"shelljs-nodecli": "0.1.1",
"typescript": "1.8.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added? It's already in peerDependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using npm 3 it is not getting installed for development
and not changing npm module
so it is nice to have

},
"keywords": [
"ast",
Expand All @@ -56,9 +57,9 @@
"betarelease": "eslint-prerelease beta"
},
"dependencies": {
"object-assign": "^4.0.1"
"object-assign": "4.0.1"
},
"peerDependencies": {
"typescript": "^1.7.3"
"typescript": "^1.8.7"
}
}