Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Use TSAbstractMethodDefinition for abstract constructors (fixes #228) #229

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Fix: Use TSAbstractMethodDefinition for abstract constructors (fixes #228) #229

merged 1 commit into from
Apr 29, 2017

Conversation

azz
Copy link
Contributor

@azz azz commented Apr 29, 2017

@jsf-clabot
Copy link

jsf-clabot commented Apr 29, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @azz! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@azz
Copy link
Contributor Author

azz commented Apr 29, 2017

Commit message is 73 characters. 🤕

@azz azz force-pushed the bug/abstract-constructor branch from 3a1f91f to 5adb9ad Compare April 29, 2017 11:43
@eslintbot
Copy link

LGTM

@azz azz mentioned this pull request Apr 29, 2017
Closed
5 tasks
@JamesHenry
Copy link
Member

Thanks for PR, @azz! The build is failing because of a configuration option, it will be fixed once this is merged #230

@azz azz force-pushed the bug/abstract-constructor branch from 5adb9ad to b594afa Compare April 29, 2017 12:11
@eslintbot
Copy link

LGTM

@azz azz force-pushed the bug/abstract-constructor branch from b594afa to 08238fc Compare April 29, 2017 13:26
@eslintbot
Copy link

LGTM

JamesHenry
JamesHenry approved these changes Apr 29, 2017
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

soda0289
soda0289 approved these changes Apr 29, 2017
View reviewed changes
Copy link
Member

@soda0289 soda0289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are also abstract class properties which we will need to support as well.

@soda0289 soda0289 merged commit 15f1173 into eslint:master Apr 29, 2017
@azz azz changed the title Fix: Use TSAbsractMethodDefinition for abstract constructors (fixes #228) Fix: Use TSAbstractMethodDefinition for abstract constructors (fixes #228) Apr 30, 2017
This was referenced Apr 30, 2017
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@soda0289 soda0289 soda0289 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azz @jsf-clabot @eslintbot @JamesHenry @soda0289