This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Chore: Wrap any parameter with modifers, not just in constructors #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pretter reprints the code from the AST, anything not in it will be gone.
So while
is invalid TypeScript, it's no good if pretter prints that as
If you have your editor set up to format on save, the modifier will just
be gone and you'll never see the error from TypeScript and will therfore
consider it a bug.
Note that the code does not explicitly support this, I just moved the code
that supports this in constructor parameters so that it applies to any parameter.
As the code parses correctly with just missing information in the AST there
are no good way to know that the printed file will be different from the original.
So while there is no intention to support invalid TS it's easier to do that in this
case than to error.