Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Change DoWhileStatement to DoStatement to match TS (fixes #180) #181

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Fix: Change DoWhileStatement to DoStatement to match TS (fixes #180) #181

merged 1 commit into from
Mar 6, 2017

Conversation

JamesHenry
Copy link
Member

No description provided.

@eslintbot
Copy link

LGTM

platinumazure
platinumazure approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question, do any previous versions of Typescript use DoWhileStatement such that you might want to have both of those in the case labels?

@JamesHenry
Copy link
Member Author

Thanks, no they don't! This was just an untested typo I guess. DoWhileStatements are not exactly that common in JS so I think that it why it was missed for so long

@JamesHenry JamesHenry merged commit 215a012 into master Mar 6, 2017
@JamesHenry JamesHenry deleted the do-while-statement branch March 6, 2017 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesHenry @eslintbot @platinumazure