This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Chore: Add test for constructor with parameters #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
soda0289
force-pushed
the
add-constructor-tests
branch
from
d1b5a00 to
9e9c69d
Compare
|
LGTM |
|
@JamesHenry do we need a test with initializers and rest params as well? |
|
the current test LGTM |
|
Yes, please! That would be perfect. Looks great so far @soda0289 |
JamesHenry
suggested changes
Feb 26, 2017
soda0289
force-pushed
the
add-constructor-tests
branch
from
9e9c69d to
8b41beb
Compare
|
LGTM |
|
@weirdpattern @JamesHenry I have added tests for rest parameters, default parameters, and destructing parameters for both class method and constructors. Let me know if you think we need any more |
|
LGTM, thank you @soda0289 |
JamesHenry
approved these changes
Feb 27, 2017
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a test that has a class constructor with two parameters.
I noticed we are missing a lot of tests for newer version of ecmascript like async/await functions. As well as tests for class methods with default parameters, deconstructed parameters, and rest parameters.
@JamesHenry Let me know if you want me to add more tests.