This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: SyntaxKind code checks, update TS peerDependency ^1.7.3 (fixes #15) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -293,11 +293,11 @@ function getTokenType(token) { | |||
| } | |||
| } | |||
|
|
|||
| if (token.kind >= 68 && token.kind <= 112) { | |||
| if (token.kind >= 70 && token.kind <= 114) { | |||
There was a problem hiding this comment.
Rather than just hardcoding the numbers, I think we should try to make use of the token boundary values: microsoft/TypeScript@b24c3a7#diff-29796169c2bd635765a9f574727f77f3R310
As far as I can tell, using SyntaxKind.FirstKeyword and SyntaxKind.LastFutureReservedWord here might inoculate us from this problem in the future.
|
Thanks for the feedback and for setting up travis - I updated the PR. It seems like it failed on node 0.10.x build, but passed on the others. NPM version issue? |
|
Looks like the TypeScript module isn't being installed because it's a peer dependency. We can probably stop testing in 0.10 at this point, so I'm not too worried. |
nzakas
added a commit
that referenced
this pull request
Mar 2, 2016
Fix: SyntaxKind code checks, update TS peerDependency ^1.7.3 (fixes #15)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15