Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Incompatible with Node between 9.0.0 and <= 9.10.0? #482

Closed
OliverJAsh opened this issue Jun 8, 2018 · 10 comments
Closed

Incompatible with Node between 9.0.0 and <= 9.10.0? #482

OliverJAsh opened this issue Jun 8, 2018 · 10 comments
Labels

Comments

@OliverJAsh
Copy link

$ yarn add -D typescript-eslint-parser
yarn add v1.6.0
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

$ node --version
v9.8.0

Is this intentional?

@JamesHenry
Copy link
Member

Tbh I just copied eslint/eslint - I am not sure of the reason behind it.

It was probably a mistake to do that, if you don’t mind submitting a PR to loosen it again, I’ll get it merged.

@platinumazure
Copy link
Member

We did it on the ESLint side to try to allow as many features as possible in the codebase-- sometimes a new feature on 10.x might get backported to a late version in 9.x. So we tried to minimize the chance of compatibility issues by using later version of the non-LTS branches.

@OliverJAsh
Copy link
Author

@platinumazure Interesting, thanks.

@JamesHenry Do you want to stick with that, or can I raise a PR to lower the range? I'm using 9.8.0…

@JamesHenry
Copy link
Member

It's a tricky one - Is there a specific reason why you are using 9.8 and not 9.10? I imagine not, you just aren't.

So you could easily upgrade node, but on the other hand it's just another point of friction to using the lib, so avoiding it might be best...

@JamesHenry
Copy link
Member

I'm going to loosen it again

@OliverJAsh
Copy link
Author

Would it be possible to release this?

@Jungwoo-An
Copy link

occurred error as same issue.

[email protected]: The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".

my node version: v8.9.4

@JamesHenry
Copy link
Member

Sorry for the delay, @OliverJAsh @Jungwoo-An, 16.0.1 is out now

@joaquinaraujo
Copy link

image

@platinumazure
Copy link
Member

@joaquinaraujo The error you're seeing is for the eslint package, not typescript-eslint-parser. ESLint has not loosened their compatibility, but typescript-eslint-parser has.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants