Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

How to enable TypeScript 2.1.x Support #149

Closed
JamesHenry opened this issue Jan 27, 2017 · 5 comments
Closed

How to enable TypeScript 2.1.x Support #149

JamesHenry opened this issue Jan 27, 2017 · 5 comments

Comments

@JamesHenry
Copy link
Member

JamesHenry commented Jan 27, 2017

This issue was originally tracked here: #128, but it has now come to its final resolution.

Unfortunately, there was an unintentional breaking change in TypeScript around how it deals with JSDoc comments within some of its public node utility methods that we rely on in this parser.

TS Issue: microsoft/TypeScript#13519

That issue has now been fixed, but will not be released as a patch version of TypeScript 2.1.x

This means that it is not possible to officially support TS 2.1.x in this parser. We will, of course, work to support 2.2.x as soon as possible.

However, because the necessary changes on our side were actually already made, it is still possible for you to use TypeScript 2.1.x on your project.

You can:

  • Install this parser using git: the branch name is ts-2.1
  • Use typescript@next as your TypeScript version (this is the master branch of TypeScript, which contains the fix)

(I think this requires npm 3+ (i.e. Node 6+) because otherwise, the peerDependency conflict would prevent you from installing that combo)

@NeoReyad
Copy link

@JamesHenry could you rebase ts-2.1

@JamesHenry
Copy link
Member Author

@NeoReyad Done!

@JamesHenry
Copy link
Member Author

Rebased the ts-2.1 branch again just now after the PR merges earlier today. I will be looking into TS 2.2.x support this week, given that it has now hit release candidate.

@JamesHenry
Copy link
Member Author

JamesHenry commented Feb 10, 2017

I'm delighted to say that the first RC of 2.2 passes all of our existing test cases on this ts-2.1 branch, so hopefully supporting TypeScript 2.2 will be much more straightforward than 2.1.

We will look to update master as soon as 2.2 is the stable release of TypeScript

@soda0289
Copy link
Member

@JamesHenry Typescript 2.2 is released! Could we merge in this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants