Skip to content

fix: prevent to report prefer-tacit in direct child of getter #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

baseballyama
Copy link
Contributor

close: #964

Copy link

graphite-app bot commented May 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Status: Merge Queue - adds this PR to the back of the merge queue
  • Status: Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@baseballyama baseballyama force-pushed the fix/964 branch 2 times, most recently from b6764b3 to 6fcfb18 Compare May 7, 2025 01:47
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (update@c5cf855). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             update     #965   +/-   ##
=========================================
  Coverage          ?   88.85%           
=========================================
  Files             ?       51           
  Lines             ?     4898           
  Branches          ?      718           
=========================================
  Hits              ?     4352           
  Misses            ?      534           
  Partials          ?       12           
Flag Coverage Δ
latest 88.85% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RebeccaStevens RebeccaStevens changed the base branch from main to update June 2, 2025 10:15
@RebeccaStevens RebeccaStevens merged commit afe34c2 into eslint-functional:update Jun 2, 2025
15 checks passed
@RebeccaStevens RebeccaStevens mentioned this pull request Jun 2, 2025
github-actions bot pushed a commit that referenced this pull request Jun 2, 2025
## [9.0.2](v9.0.1...v9.0.2) (2025-06-02)

### Bug Fixes

* mark no-throw-statements rule as requiring type checking ([#963](#963)) ([b06c25c](b06c25c))
* prevent to report `prefer-tacit` in direct child of getter ([#965](#965)) ([afe34c2](afe34c2))
Copy link

github-actions bot commented Jun 2, 2025

🎉 This PR is included in version 9.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Released It's now live.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: functional/prefer-tacit has false positive in getter
2 participants