Skip to content

new prefer-readonly-type rule #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

Conversation

RebeccaStevens
Copy link
Collaborator

fix #153

@RebeccaStevens RebeccaStevens added Breaking Change This change will require a new major release. Type: Enhancement Enhancement of the code, not introducing new features. labels Jul 25, 2021
@RebeccaStevens
Copy link
Collaborator Author

Waiting on typescript-eslint/typescript-eslint#3658

@RebeccaStevens RebeccaStevens added the Status: Blocked Progress on this issue is currently not possible. label Jul 26, 2021
@RebeccaStevens RebeccaStevens force-pushed the next branch 3 times, most recently from 59c20d3 to ecfc4fe Compare July 30, 2021 00:38
@RebeccaStevens RebeccaStevens force-pushed the new-prefer-readonly-type branch from 25807fc to f603bf2 Compare July 30, 2021 01:39
@RebeccaStevens RebeccaStevens force-pushed the next branch 2 times, most recently from 96c362b to f031720 Compare July 31, 2021 03:24
@RebeccaStevens RebeccaStevens force-pushed the new-prefer-readonly-type branch from f603bf2 to 32b6761 Compare July 31, 2021 03:35
@RebeccaStevens RebeccaStevens force-pushed the new-prefer-readonly-type branch from 32b6761 to 6ae1d01 Compare July 31, 2021 03:51
@RebeccaStevens RebeccaStevens force-pushed the next branch 7 times, most recently from 32b31f4 to 5098242 Compare July 31, 2021 08:06
@RebeccaStevens RebeccaStevens force-pushed the new-prefer-readonly-type branch from 6ae1d01 to 2efa1b3 Compare July 31, 2021 08:08
@RebeccaStevens RebeccaStevens force-pushed the new-prefer-readonly-type branch from 2efa1b3 to 1bddef2 Compare July 31, 2021 08:10
BREAKING CHANGE: Node 12.4.0 or new is now required
BREAKING CHANGE: removed stylitic ruleset in favor of stylistic ruleset
Remove dev-dependencies that aren't needed for testing and aren't compatable with all node versions
being tested against.
BREAKING CHANGE: rule "prefer-type-literal" has been removed.
removed:
 - @typescript-eslint/explicit-function-return-type

added:
 - @typescript-eslint/prefer-readonly
 - @typescript-eslint/prefer-readonly-parameter-types
 - @typescript-eslint/switch-exhaustiveness-check
 - @typescript-eslint/prefer-const

BREAKING CHANGE: update recommended external rules
@RebeccaStevens RebeccaStevens force-pushed the new-prefer-readonly-type branch from 1bddef2 to 0e75bbe Compare July 31, 2021 08:13
@RebeccaStevens RebeccaStevens force-pushed the next branch 3 times, most recently from b82622f to 0e2c490 Compare August 3, 2021 02:00
@RebeccaStevens
Copy link
Collaborator Author

Closing in favor of #255

@RebeccaStevens RebeccaStevens deleted the new-prefer-readonly-type branch August 8, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change will require a new major release. Status: Blocked Progress on this issue is currently not possible. Type: Enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant